Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-13660][SQL][Tests] ContinuousQuerySuite floods the logs with garbage #11703

Closed
wants to merge 1 commit into from
Closed

[SPARK-13660][SQL][Tests] ContinuousQuerySuite floods the logs with garbage #11703

wants to merge 1 commit into from

Conversation

keypointt
Copy link
Contributor

What changes were proposed in this pull request?

Use method 'testQuietly' to avoid ContinuousQuerySuite flooding the console logs with garbage

Make ContinuousQuerySuite not output logs to the console. The logs will still output to unit-tests.log.

How was this patch tested?

Just check Jenkins output.

@zsxwing
Copy link
Member

zsxwing commented Mar 14, 2016

ok to test

@SparkQA
Copy link

SparkQA commented Mar 14, 2016

Test build #53111 has finished for PR 11703 at commit 4554854.

  • This patch fails MiMa tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Mar 14, 2016

Test build #53125 has finished for PR 11703 at commit 0813e81.

  • This patch fails Scala style tests.
  • This patch does not merge cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Mar 14, 2016

Test build #53126 has finished for PR 11703 at commit 1828111.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun
Copy link
Member

Hi, @keypointt .
FYI, the MiMa failures seem to irrelevant to your PR. It occurs on #11700 , too.

@keypointt
Copy link
Contributor Author

@dongjoon-hyun I think it's just missing some exclude claims? I had similar issues before, and what I did before was adding those ones to exclude claims

@dongjoon-hyun
Copy link
Member

Sure, you're right. If the claims are correct, you did the right things. I meant the MiMa status is strange now. :)

@keypointt
Copy link
Contributor Author

I've just now tested on my local machine by "./dev/mima" and it passed testing. Let's see what happens on Jenkins.
If I'm doing it in a wrong way please let me know, thanks 😄

@dongjoon-hyun
Copy link
Member

Could you try again './dev/mima' with only the first commit locally?
I'm sure you can pass at this time. :)

By the way, I'm not a Spark committer, too.

@keypointt
Copy link
Contributor Author

Oh I tried './dev/mima' on my first commit, and it failed both locally and on Jenkins, that's why I started modifying the mima file

@keypointt
Copy link
Contributor Author

@zsxwing I just had a quick look on Jenkins, and all the recent PRs are failed by this MiMa test, could you please have a look at my changes to make sure I'm doing it right?

@zsxwing
Copy link
Member

zsxwing commented Mar 14, 2016

@zsxwing I just had a quick look on Jenkins, and all the recent PRs are failed by this MiMa test, could you please have a look at my changes to make sure I'm doing it right?

I think your fix is correct. Let's see if it passes all tests

@andrewor14
Copy link
Contributor

Let's not attempt to fix the MIMA issues in this patch; SPARK-13660 has nothing to do with MIMA.

@SparkQA
Copy link

SparkQA commented Mar 15, 2016

Test build #53131 has finished for PR 11703 at commit 5871f81.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

rxin
rxin reviewed Mar 15, 2016
View reviewed changes
project/MimaExcludes.scala
@@ -319,6 +319,68 @@ object MimaExcludes {
ProblemFilters.exclude[IncompatibleResultTypeProblem]("org.apache.spark.ml.classification.LogisticRegressionSummary.predictions"),
ProblemFilters.exclude[MissingMethodProblem]("org.apache.spark.ml.classification.LogisticRegressionSummary.predictions")
) ++ Seq(
// [SPARK-13660][SQL][Tests] ContinuousQuerySuite floods the logs with garbage
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you undo all the mima changes? there was a problem with the build and we fixed that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, I'll undo it

@rxin
Copy link
Contributor

rxin commented Mar 15, 2016

Thanks - merging in master.

@SparkQA
Copy link

SparkQA commented Mar 15, 2016

Test build #53168 has finished for PR 11703 at commit 4554854.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@asfgit asfgit closed this in 10251a7 Mar 15, 2016
@keypointt
Copy link
Contributor Author

Thanks a lot 👍

roygao94 pushed a commit to roygao94/spark that referenced this pull request Mar 22, 2016
@keypointt @roygao94
[SPARK-13660][SQL][TESTS] ContinuousQuerySuite floods the logs with g…
bd684f5 
…arbage

## What changes were proposed in this pull request?

Use method 'testQuietly' to avoid ContinuousQuerySuite flooding the console logs with garbage

Make ContinuousQuerySuite not output logs to the console. The logs will still output to unit-tests.log.

## How was this patch tested?

Just check Jenkins output.

Author: Xin Ren <iamshrek@126.com>

Closes apache#11703 from keypointt/SPARK-13660.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@keypointt @zsxwing @SparkQA @dongjoon-hyun @andrewor14 @rxin